Skip to content
Snippets Groups Projects
Commit 514a145c authored by Pavel Antonov's avatar Pavel Antonov :asterisk:
Browse files

Merge branch 'feature/2837-FixTransport' into 'master'

Исправлена ошибка в транспорте сервиса Logs

See merge request perxis/perxis-go!408
parents 2870180e cac9377b
No related branches found
No related tags found
No related merge requests found
...@@ -106,4 +106,24 @@ func TestFindResult(t *testing.T) { ...@@ -106,4 +106,24 @@ func TestFindResult(t *testing.T) {
assert.Equal(t, []string{"timestamp"}, res.Options.Sort) assert.Equal(t, []string{"timestamp"}, res.Options.Sort)
assert.Equal(t, []string{"level"}, res.Options.Fields) assert.Equal(t, []string{"level"}, res.Options.Fields)
}) })
t.Run("From PB: with nil filter and options", func(t *testing.T) {
res := FindResultFromPB(&pb.FindResult{Filter: nil, Options: nil})
assert.NotNil(t, res)
assert.Nil(t, res.Options)
assert.Nil(t, res.Filter)
})
t.Run("To PB: with nil filter and options", func(t *testing.T) {
res := FindResultToPB(&FindResult{Filter: nil, Options: nil})
assert.NotNil(t, res)
assert.Nil(t, res.Options)
assert.Nil(t, res.Filter)
})
t.Run("From PB: nil", func(t *testing.T) {
res := FindResultFromPB(nil)
assert.Nil(t, res)
})
t.Run("To PB: nil", func(t *testing.T) {
res := FindResultToPB(nil)
assert.Nil(t, res)
})
} }
...@@ -61,6 +61,10 @@ type FindOptions struct { ...@@ -61,6 +61,10 @@ type FindOptions struct {
// FindResultToPB перевод в proto представление FindResult // FindResultToPB перевод в proto представление FindResult
func FindResultToPB(result *FindResult) *pb.FindResult { func FindResultToPB(result *FindResult) *pb.FindResult {
if result == nil {
return nil
}
findResult := &pb.FindResult{Total: 0} // поле стало deprecated всегда возвращаем 0 findResult := &pb.FindResult{Total: 0} // поле стало deprecated всегда возвращаем 0
entries := make([]*pb.LogEntry, 0, len(result.Entries)) entries := make([]*pb.LogEntry, 0, len(result.Entries))
...@@ -70,7 +74,7 @@ func FindResultToPB(result *FindResult) *pb.FindResult { ...@@ -70,7 +74,7 @@ func FindResultToPB(result *FindResult) *pb.FindResult {
findResult.Entries = entries findResult.Entries = entries
if result.Filter != nil { if result.Filter != nil {
findResult.Filter.Q = result.Filter.Q findResult.Filter = &pb.Filter{Q: result.Filter.Q}
} }
if result.Options != nil { if result.Options != nil {
findResult.Options = FindOptionsToPB(result.Options) findResult.Options = FindOptionsToPB(result.Options)
...@@ -89,7 +93,11 @@ func FindResultToPB(result *FindResult) *pb.FindResult { ...@@ -89,7 +93,11 @@ func FindResultToPB(result *FindResult) *pb.FindResult {
// FindResultFromPB перевод из proto представления FindResult // FindResultFromPB перевод из proto представления FindResult
func FindResultFromPB(result *pb.FindResult) *FindResult { func FindResultFromPB(result *pb.FindResult) *FindResult {
findResult := new(FindResult) if result == nil {
return nil
}
findResult := &FindResult{}
entries := make([]*Entry, 0, len(result.Entries)) entries := make([]*Entry, 0, len(result.Entries))
for _, e := range result.Entries { for _, e := range result.Entries {
...@@ -98,7 +106,7 @@ func FindResultFromPB(result *pb.FindResult) *FindResult { ...@@ -98,7 +106,7 @@ func FindResultFromPB(result *pb.FindResult) *FindResult {
findResult.Entries = entries findResult.Entries = entries
if result.Filter != nil { if result.Filter != nil {
findResult.Filter.Q = result.Filter.Q findResult.Filter = &Filter{Q: result.Filter.Q}
} }
if result.Options != nil { if result.Options != nil {
findResult.Options = FindOptionsFromPB(result.Options) findResult.Options = FindOptionsFromPB(result.Options)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment