Skip to content
Snippets Groups Projects
Commit cac9377b authored by Alex Petraky's avatar Alex Petraky :basketball_player_tone1: Committed by Pavel Antonov
Browse files

Исправлена ошибка в транспорте сервиса Logs

parent 2870180e
No related branches found
No related tags found
No related merge requests found
......@@ -106,4 +106,24 @@ func TestFindResult(t *testing.T) {
assert.Equal(t, []string{"timestamp"}, res.Options.Sort)
assert.Equal(t, []string{"level"}, res.Options.Fields)
})
t.Run("From PB: with nil filter and options", func(t *testing.T) {
res := FindResultFromPB(&pb.FindResult{Filter: nil, Options: nil})
assert.NotNil(t, res)
assert.Nil(t, res.Options)
assert.Nil(t, res.Filter)
})
t.Run("To PB: with nil filter and options", func(t *testing.T) {
res := FindResultToPB(&FindResult{Filter: nil, Options: nil})
assert.NotNil(t, res)
assert.Nil(t, res.Options)
assert.Nil(t, res.Filter)
})
t.Run("From PB: nil", func(t *testing.T) {
res := FindResultFromPB(nil)
assert.Nil(t, res)
})
t.Run("To PB: nil", func(t *testing.T) {
res := FindResultToPB(nil)
assert.Nil(t, res)
})
}
......@@ -61,6 +61,10 @@ type FindOptions struct {
// FindResultToPB перевод в proto представление FindResult
func FindResultToPB(result *FindResult) *pb.FindResult {
if result == nil {
return nil
}
findResult := &pb.FindResult{Total: 0} // поле стало deprecated всегда возвращаем 0
entries := make([]*pb.LogEntry, 0, len(result.Entries))
......@@ -70,7 +74,7 @@ func FindResultToPB(result *FindResult) *pb.FindResult {
findResult.Entries = entries
if result.Filter != nil {
findResult.Filter.Q = result.Filter.Q
findResult.Filter = &pb.Filter{Q: result.Filter.Q}
}
if result.Options != nil {
findResult.Options = FindOptionsToPB(result.Options)
......@@ -89,7 +93,11 @@ func FindResultToPB(result *FindResult) *pb.FindResult {
// FindResultFromPB перевод из proto представления FindResult
func FindResultFromPB(result *pb.FindResult) *FindResult {
findResult := new(FindResult)
if result == nil {
return nil
}
findResult := &FindResult{}
entries := make([]*Entry, 0, len(result.Entries))
for _, e := range result.Entries {
......@@ -98,7 +106,7 @@ func FindResultFromPB(result *pb.FindResult) *FindResult {
findResult.Entries = entries
if result.Filter != nil {
findResult.Filter.Q = result.Filter.Q
findResult.Filter = &Filter{Q: result.Filter.Q}
}
if result.Options != nil {
findResult.Options = FindOptionsFromPB(result.Options)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment