fix tests

pkg/extension/server_test.go

@@ -121,10 +121,10 @@ func TestServer_Action(t *testing.T) {
 		services map[string]Extension
 		in       *ActionRequest
 		want     *ActionResponse
-		wantErr  assert.ErrorAssertionFunc
+		wantErr  string
 	}{
 		{
-			name:     "OK (grpc)",
+			name:     "GRPC",
 			services: map[string]Extension{"test-extension": getDummyExtension("test-extension")},
 			in: &ActionRequest{
 				Action:  "grpc:///test-extension/test-action",
@@ -132,10 +132,20 @@ func TestServer_Action(t *testing.T) {
 				EnvId:   "env",
 			},
 			want: &ActionResponse{State: ResponseDone},
-			wantErr: assert.NoError,
 		},
 		{
-			name:     "OK (deprecated call)",
+			name:     "invalid schema",
+			services: map[string]Extension{"test-extension": getDummyExtension("test-extension")},
+			in: &ActionRequest{
+				Action:  "some:///space/env/coll",
+				SpaceId: "sp",
+				EnvId:   "env",
+			},
+			want:    &ActionResponse{State: ResponseDone},
+			wantErr: "extension ID required",
+		},
+		{
+			name:     "Deprecated call",
 			services: map[string]Extension{"test-extension": getDummyExtension("test-extension")},
 			in: &ActionRequest{
 				Action:    "test-action",
@@ -144,10 +154,9 @@ func TestServer_Action(t *testing.T) {
 				Extension: "test-extension",
 			},
 			want: &ActionResponse{State: ResponseDone},
-			wantErr: assert.NoError,
 		},
 		{
-			name:     "Error (unknown extension)",
+			name:     "unknown extension",
 			services: map[string]Extension{"test-extension": getDummyExtension("test-extension")},
 			in: &ActionRequest{
 				Action:  "grpc:///test-extension-2/test-action",
@@ -155,10 +164,10 @@ func TestServer_Action(t *testing.T) {
 				EnvId:   "env",
 			},
 			want:    nil,
-			wantErr: assert.Error,
+			wantErr: ErrUnknownExtension.Error(),
 		},
 		{
-			name:     "Error (deprecated call, no extension)",
+			name:     "Deprecated call, without extension",
 			services: map[string]Extension{"test-extension": getDummyExtension("test-extension")},
 			in: &ActionRequest{
 				Action:  "test-action",
@@ -166,17 +175,17 @@ func TestServer_Action(t *testing.T) {
 				EnvId:   "env",
 			},
 			want:    nil,
-			wantErr: assert.Error,
+			wantErr: "extension ID required",
 		},
 		{
-			name:     "Error (deprecated call, no action and extension)",
+			name:     "Deprecated call, without action and extension)",
 			services: map[string]Extension{"test-extension": getDummyExtension("test-extension")},
 			in: &ActionRequest{
 				SpaceId: "sp",
 				EnvId:   "env",
 			},
 			want:    nil,
-			wantErr: assert.Error,
+			wantErr: "extension ID required",
 		},
 	}
 	for _, tt := range tests {
@@ -186,7 +195,8 @@ func TestServer_Action(t *testing.T) {
 				services: tt.services,
 			}
 			got, err := srv.Action(context.Background(), tt.in)
-			if !tt.wantErr(t, err, fmt.Sprintf("Action(%v)", tt.in)) {
+			if tt.wantErr != "" {
+				assert.EqualErrorf(t, err, tt.wantErr, fmt.Sprintf("Action(%v)", tt.in))
 				return
 			}
 			assert.Equalf(t, tt.want, got, "Action(%v)", tt.in)