правки по ПР:

- ошибки перенесены в переменные/константы
- часть ошибки убрана в детали
- добавлен Trim и проверка на пустоту в ValidateID()

pkg/id/id.go

@@ -2,36 +2,47 @@ package id
 
 import (
 	"regexp"
+	"strings"
 
 	"git.perx.ru/perxis/perxis-go/pkg/errors"
 	"github.com/rs/xid"
 )
 
 const (
-	IDMaxLength   = 64
-	NameMaxLength = 256
+	MaxLengthID   = 64
+	MaxLengthName = 256
 )
 
-var isValidID = regexp.MustCompile(`^[A-Za-z][A-Za-z0-9-_]*$`).MatchString
+var (
+	ErrEmptyID    = errors.New("empty ID")
+	ErrNotValidID = errors.New("id contains invalid characters")
+	ErrLongID     = errors.New("id too long (max 64 symbols)")
+	ErrLongName   = errors.New("name too long (max 256 symbols)")
+	isValidID     = regexp.MustCompile(`^[A-Za-z][A-Za-z0-9-_]*$`).MatchString
+)
 
 func GenerateNewID() string {
 	return xid.New().String()
 }
 
 func ValidateID(id string) error {
-	if len(id) > IDMaxLength {
-		return errors.New("invalid id: too long (max 64 symbols)")
+	trimmedID := strings.TrimSpace(id)
+	if trimmedID == "" {
+		return ErrEmptyID
+	}
+	if len(trimmedID) > MaxLengthID {
+		return ErrLongID
 	}
-	if !isValidID(id) {
-		return errors.New("invalid id: must begin with latin letters and contain latin letters, numbers or '-', '_'")
+	if !isValidID(trimmedID) {
+		return errors.WithDetail(ErrNotValidID, "must begin with latin letters and contain latin letters, numbers or '-', '_'")
 	}
 
 	return nil
 }
 
 func ValidateName(name string) error {
-	if len(name) > NameMaxLength {
-		return errors.New("invalid name: too long (max 256 symbols)")
+	if len(name) > MaxLengthName {
+		return ErrLongName
 	}
 
 	return nil

pkg/id/id_test.go

@@ -28,11 +28,6 @@ func TestValidateID(t *testing.T) {
 			"1test",
 			true,
 		},
-		{
-			"Fail, ID starts with whitespace",
-			" test",
-			true,
-		},
 		{
 			"Fail, ID to long",
 			"9QoulAlFbIcnQYLSudMistN1IczCWrXUTtN5EgNQJd516DN9UjXYJxieJ1RcsNcs1",