Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
P
perxis-go
Manage
Activity
Members
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Package Registry
Operate
Terraform modules
Analyze
Contributor analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
perxis
perxis-go
Commits
4a3f8301
Commit
4a3f8301
authored
11 months ago
by
Anton Sattarov
Browse files
Options
Downloads
Patches
Plain Diff
Исправлена ошибка при которой была возможность изменить обьект находящийся в кеше Items
parent
62b3db3e
No related branches found
No related tags found
No related merge requests found
Changes
2
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
pkg/items/middleware/caching_middleware.go
+5
-5
5 additions, 5 deletions
pkg/items/middleware/caching_middleware.go
pkg/items/middleware/caching_middleware_test.go
+40
-39
40 additions, 39 deletions
pkg/items/middleware/caching_middleware_test.go
with
45 additions
and
44 deletions
pkg/items/middleware/caching_middleware.go
+
5
−
5
View file @
4a3f8301
...
...
@@ -35,7 +35,7 @@ func (m cachingMiddleware) Get(ctx context.Context, spaceId, envId, collectionId
value
,
e
:=
m
.
cache
.
Get
(
makeKey
(
spaceId
,
envId
,
collectionId
,
itemId
))
if
e
==
nil
{
return
value
.
(
*
service
.
Item
),
err
return
value
.
(
*
service
.
Item
)
.
Clone
()
,
err
}
itm
,
err
=
m
.
Items
.
Get
(
ctx
,
spaceId
,
envId
,
collectionId
,
itemId
,
options
...
)
if
err
==
nil
{
...
...
@@ -43,9 +43,9 @@ func (m cachingMiddleware) Get(ctx context.Context, spaceId, envId, collectionId
if
err
!=
nil
{
return
nil
,
err
}
m
.
cache
.
Set
(
makeKey
(
itm
.
SpaceID
,
env
.
ID
,
itm
.
CollectionID
,
itm
.
ID
),
itm
)
m
.
cache
.
Set
(
makeKey
(
itm
.
SpaceID
,
env
.
ID
,
itm
.
CollectionID
,
itm
.
ID
),
itm
.
Clone
()
)
for
_
,
al
:=
range
env
.
Aliases
{
m
.
cache
.
Set
(
makeKey
(
itm
.
SpaceID
,
al
,
itm
.
CollectionID
,
itm
.
ID
),
itm
)
m
.
cache
.
Set
(
makeKey
(
itm
.
SpaceID
,
al
,
itm
.
CollectionID
,
itm
.
ID
),
itm
.
Clone
()
)
}
}
return
itm
,
err
...
...
@@ -132,7 +132,7 @@ func (m cachingMiddleware) GetPublished(ctx context.Context, spaceId, envId, col
if
e
==
nil
{
value
:=
val
.
(
map
[
string
]
*
service
.
Item
)
if
i
,
ok
:=
value
[
opts
.
LocaleID
];
ok
{
return
i
,
nil
return
i
.
Clone
()
,
nil
}
}
...
...
@@ -147,7 +147,7 @@ func (m cachingMiddleware) GetPublished(ctx context.Context, spaceId, envId, col
if
val
!=
nil
{
value
=
val
.
(
map
[
string
]
*
service
.
Item
)
}
value
[
opts
.
LocaleID
]
=
itm
value
[
opts
.
LocaleID
]
=
itm
.
Clone
()
m
.
cachePublished
.
Set
(
makeKey
(
itm
.
SpaceID
,
env
.
ID
,
itm
.
CollectionID
,
itm
.
ID
),
value
)
for
_
,
al
:=
range
env
.
Aliases
{
m
.
cachePublished
.
Set
(
makeKey
(
itm
.
SpaceID
,
al
,
itm
.
CollectionID
,
itm
.
ID
),
value
)
...
...
This diff is collapsed.
Click to expand it.
pkg/items/middleware/caching_middleware_test.go
+
40
−
39
View file @
4a3f8301
This diff is collapsed.
Click to expand it.
Pavel Antonov
@softzilla
mentioned in commit
0f5d76df
·
11 months ago
mentioned in commit
0f5d76df
mentioned in commit 0f5d76dff8be228934f555add73d7df51dea6b33
Toggle commit list
Pavel Antonov
@softzilla
mentioned in commit
923ccdd6
·
11 months ago
mentioned in commit
923ccdd6
mentioned in commit 923ccdd68cdd48f9e61d093b40de4eea114a5bed
Toggle commit list
Pavel Antonov
@softzilla
mentioned in commit
6dd858fe
·
11 months ago
mentioned in commit
6dd858fe
mentioned in commit 6dd858fe3edd7086cf90650db132a20141712cad
Toggle commit list
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment