From 08c425c93923ebb206e9fd2834a5128e41628c56 Mon Sep 17 00:00:00 2001
From: Semyon Krestyaninov <ensiouel@gmail.com>
Date: Tue, 20 Feb 2024 06:42:04 +0300
Subject: [PATCH] fix tests names and add new testcase

---
 zap/channels_test.go | 25 +++++++++++++++++--------
 1 file changed, 17 insertions(+), 8 deletions(-)

diff --git a/zap/channels_test.go b/zap/channels_test.go
index ba1a70eb..ac4c5c9a 100644
--- a/zap/channels_test.go
+++ b/zap/channels_test.go
@@ -8,20 +8,17 @@ import (
 	"go.uber.org/zap/zaptest/observer"
 )
 
-func TestNewChannelCore_WriteSingleChannel(t *testing.T) {
+func TestWithChannel_WriteSingleChannel(t *testing.T) {
 	core, logs := observer.New(zapcore.InfoLevel)
 	core = WithChannel(core, "test")
 
-	err := core.Write(zapcore.Entry{Message: "msg"}, []zapcore.Field{Channels("test")})
-	require.NoError(t, err)
-
-	err = core.Write(zapcore.Entry{Message: "msg"}, []zapcore.Field{Channels("empty")}) // запись не попадет в лог
-	require.NoError(t, err)
+	require.NoError(t, core.Write(zapcore.Entry{Message: "msg"}, []zapcore.Field{Channels("test")}))
+	require.NoError(t, core.Write(zapcore.Entry{Message: "msg"}, []zapcore.Field{Channels("empty")})) // запись не попадет в лог
 
 	require.Equal(t, 1, logs.Len())
 }
 
-func TestNewChannelCore_WriteMultiplyChannels(t *testing.T) {
+func TestWithChannel_WriteMultiplyChannels(t *testing.T) {
 	core, logs := observer.New(zapcore.InfoLevel)
 
 	core = zapcore.NewTee(
@@ -30,10 +27,11 @@ func TestNewChannelCore_WriteMultiplyChannels(t *testing.T) {
 	)
 
 	require.NoError(t, core.Write(zapcore.Entry{Message: "msg"}, []zapcore.Field{Channels("test1", "test2")})) // запись попадет сразу в 2 core
+
 	require.Equal(t, 2, logs.Len())
 }
 
-func TestNewDefaultChannelCore(t *testing.T) {
+func TestWithDefaultChannels(t *testing.T) {
 	core, logs := observer.New(zapcore.InfoLevel)
 
 	core = zapcore.NewTee(
@@ -47,3 +45,14 @@ func TestNewDefaultChannelCore(t *testing.T) {
 
 	require.Equal(t, 2, logs.Len())
 }
+
+func TestWithChannels(t *testing.T) {
+	core, logs := observer.New(zapcore.InfoLevel)
+
+	core = WithChannels(core, "test1", "test2")
+
+	require.NoError(t, core.Write(zapcore.Entry{Message: "msg"}, []zapcore.Field{Channels("test1")}))
+	require.NoError(t, core.Write(zapcore.Entry{Message: "msg"}, []zapcore.Field{Channels("test2")}))
+
+	require.Equal(t, 2, logs.Len())
+}
-- 
GitLab